On Tue, Oct 03, 2023 at 04:18:51PM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct nfp_eth_table.
>
> Cc: Simon Horman <simon.hor...@corigine.com>
> Cc: Jakub Kicinski <k...@kernel.org>
> Cc: "David S. Miller" <da...@davemloft.net>
> Cc: Eric Dumazet <eduma...@google.com>
> Cc: Paolo Abeni <pab...@redhat.com>
> Cc: Yinjun Zhang <yinjun.zh...@corigine.com>
> Cc: Leon Romanovsky <l...@kernel.org>
> Cc: Yu Xiao <yu.x...@corigine.com>
> Cc: Sixiang Chen <sixiang.c...@corigine.com>
> Cc: oss-driv...@corigine.com
> Cc: net...@vger.kernel.org
> Link:
> https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> [1]
> Signed-off-by: Kees Cook <keesc...@chromium.org>
Likewise here, thanks for updating
Acked-by: Louis Peens <louis.pe...@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h
> b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h
> index 6e044ac04917..00264af13b49 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h
> +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h
> @@ -241,7 +241,7 @@ struct nfp_eth_table {
>
> u64 link_modes_supp[2];
> u64 link_modes_ad[2];
> - } ports[];
> + } ports[] __counted_by(count);
> };
>
> struct nfp_eth_table *nfp_eth_read_ports(struct nfp_cpp *cpp);
> --
> 2.34.1
>
