On Fri, Sep 22, 2023 at 10:51:51AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct uv_rtc_timer_head. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Steve Wahl <steve.w...@hpe.com> > Cc: Mike Travis <mike.tra...@hpe.com> > Cc: Dimitri Sivanich <dimitri.sivan...@hpe.com> > Cc: Russ Anderson <russ.ander...@hpe.com> > Cc: Darren Hart <dvh...@infradead.org> > Cc: Andy Shevchenko <a...@infradead.org> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Ingo Molnar <mi...@redhat.com> > Cc: Borislav Petkov <b...@alien8.de> > Cc: Dave Hansen <dave.han...@linux.intel.com> > Cc: x...@kernel.org > Cc: "H. Peter Anvin" <h...@zytor.com> > Cc: platform-driver-...@vger.kernel.org > Signed-off-by: Kees Cook <keesc...@chromium.org> > > --- > arch/x86/platform/uv/uv_time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/platform/uv/uv_time.c b/arch/x86/platform/uv/uv_time.c > index 54663f3e00cb..ff5afc8a5a41 100644 > --- a/arch/x86/platform/uv/uv_time.c > +++ b/arch/x86/platform/uv/uv_time.c > @@ -53,7 +53,7 @@ struct uv_rtc_timer_head { > struct { > int lcpu; /* systemwide logical cpu number */ > u64 expires; /* next timer expiration for this cpu */ > - } cpu[]; > + } cpu[] __counted_by(ncpus); > }; > > /* > -- > 2.34.1
Looks good, thanks. Reviewed-by: Steve Wahl <steve.w...@hpe.com> -- Steve Wahl, Hewlett Packard Enterprise
