On Fri, Sep 22, 2023 at 10:54:02AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct
> mc13xxx_regulator_priv.
>
> [1]
> https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Liam Girdwood <lgirdw...@gmail.com>
> Cc: Mark Brown <broo...@kernel.org>
> Signed-off-by: Kees Cook <keesc...@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavo...@kernel.org>
Thanks
--
Gustavo
> ---
> drivers/regulator/mc13xxx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/mc13xxx.h b/drivers/regulator/mc13xxx.h
> index e03279dc43f4..057aaef6f086 100644
> --- a/drivers/regulator/mc13xxx.h
> +++ b/drivers/regulator/mc13xxx.h
> @@ -24,7 +24,7 @@ struct mc13xxx_regulator_priv {
> u32 powermisc_pwgt_state;
> struct mc13xxx_regulator *mc13xxx_regulators;
> int num_regulators;
> - struct regulator_dev *regulators[];
> + struct regulator_dev *regulators[] __counted_by(num_regulators);
> };
>
> extern int mc13xxx_fixed_regulator_set_voltage(struct regulator_dev *rdev,
> --
> 2.34.1
>
>
