Quite new at git I want to start to commit to the mysql RA.
There are minor changes, I would call aesthetic.
There are some things I would like to change. And some questions also:
1.
OCF_RESKEY_binary_default
a. First I would like to s/mysqld_safe/mysqld/
The function of mysqld_safe is to restart mysqld it it shut down uncleanly.
IMHO now this is the task of the RA/pacemake anyway
b. Don't set full pathnames as default. This should be handled by PATH anyway.
The admin is free to specify the full path anyway
2.
OCF_RESKEY_datadir_default, socket_default, pid_default etc.
MySQL ships with my_print_defaults() with that you can read all the options out
of the my.cnf.
No need for redundant defining.
3. Define OCF_RESKEY_operator
This is going to be a new variable. There you can put your operator
credentials. So no need to define user and password in crm. You can have
different credentials per node.
4. Redifine MYSQL or define MYSQLCLI
i.e. MYSQLCLI="${OCF_RESKEY_binary} --defaults-file=${OCF_RESKEY_config}
--defaults-extra-file=${OCF_RESKEY_operator}"
or something similar
5. mysql_start()
mysql_start mixes starting mysqld and initialing the database. Maybe it is a
good idea to split this.
6. is_slave()
#v+
# "SHOW SLAVE STATUS" returns an empty set if instance is not a
# replication slave
#v-
Even if show slave status returns somehing it is no slave either.
7. check_slave()
dependig on $last_errno there is an error given.
This error could be an artefact also.
8. Delete the use of tmpfiles. Parsing slave status etc. doesn't need any
tmpfile.
9. Make a more safe failover. I.e. By waiting till the replicationlag was
applied before promoted to master.
(this assumes you got the data in the relaylog of course.
This are some ideas.
Im still hesitating with the notify options and still trying to understand that
stuff :)
Please feel free to comment.
Regards
Erkan (learned most of that RA)
--
über den grenzen muß die freiheit wohl wolkenlos sein
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
