Patch is attached.
I wasn't able to create a pull request since there is already one existing
and I don't know how to delete it.
On Mon, Jun 20, 2011 at 11:24 AM, Serge Dubrouski <[email protected]>wrote:
>
>
> On Mon, Jun 20, 2011 at 11:06 AM, Vadym Chepkov <[email protected]>wrote:
>
>>
>> On Jun 20, 2011, at 12:33 PM, Florian Haas wrote:
>>
>> > On 2011-06-20 18:17, Serge Dubrouski wrote:
>> >>> Well suppose all of /master is on DRBD (or shared storage), and it's a
>> >>> subdirectory of that mount point that PostgreSQL uses. So on the
>> >>> inactive node /master would be there, but /master/sql/data would not.
>> >>> That's a legitimate use case, in my opinion, and the RA should behave
>> >>> nicely in that case. Should it not?
>> >>>
>> >>
>> >> Hmm, didn't think about this case. Ok, I'll fix it.
>> >>
>> >> BTW, this behaviour wasn't introduced with the latest changes, it was
>> always
>> >> there,
>> >
>> > Then double kudos to Vadym for spotting it now. :)
>> >
>>
>> It definitely didn't happen with the previous version I had - 1.0.4 and I
>> didn't change cluster configuration.
>>
>> I think it comes from this addition to pgsql_validate_all
>>
>>
>> + if ! runasowner "test -w $OCF_RESKEY_pgdata"; then
>> + ocf_log err "Directory $OCF_RESKEY_pgdata is not writable by
>> $OCF_RESKEY_pgdba"
>> + exit $OCF_ERR_PERM;
>> fi
>>
>
> Previous RPM for RedHat could be very old. But anyway I'll fix this bug
> later today.
>
>
>>
>> which is called for each single operation, not just for validate-all.
>>
>>
>> Vadym
>>
>>
>>
>>
>> _______________________________________________
>> Linux-HA mailing list
>> [email protected]
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha
>> See also: http://linux-ha.org/ReportingProblems
>>
>
>
>
> --
> Serge Dubrouski.
>
--
Serge Dubrouski.
--- a/heartbeat/pgsql
+++ b/heartbeat/pgsql
@@ -540,9 +540,13 @@ pgsql_validate_all() {
return $OCF_ERR_INSTALLED;
fi
- if ! runasowner "test -w $OCF_RESKEY_pgdata"; then
- ocf_log err "Directory $OCF_RESKEY_pgdata is not writable by $OCF_RESKE
- exit $OCF_ERR_PERM;
+ if ocf_is_probe; then
+ ocf_log info "Don't check $OCF_RESKEY_pgdata during probe"
+ else
+ if ! runasowner "test -w $OCF_RESKEY_pgdata"; then
+ ocf_log err "Directory $OCF_RESKEY_pgdata is not writable by $OCF_R
+ exit $OCF_ERR_PERM;
+ fi
fi
if [ -n "$OCF_RESKEY_monitor_user" -a ! -n "$OCF_RESKEY_monitor_password" ]
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
