On Tue, Mar 01, 2011 at 03:45:57PM +0100, Dejan Muhamedagic wrote:
> On Fri, Feb 25, 2011 at 11:38:50PM +0100, Lars Ellenberg wrote:
> > On Fri, Feb 25, 2011 at 06:10:27PM +0100, Dejan Muhamedagic wrote:
> > > Hi,
> > > 
> > > On Thu, Feb 24, 2011 at 09:08:45AM -0800, Avestan wrote:
> > > > 
> > > > Hello Dejan,
> > > > 
> > > > Thanks for your information.  After looking to the bug filed and 
> > > > solution by
> > > > Dave Blaschke "The link you pointed to..."
> > > > 
> > > > If I understand this correctly, This is really a work around the issue 
> > > > that
> > > > some telnet apps do not
> > > > issue "Escape character is '^]'" when logging in while others do.
> > > 
> > > Right. And apparently nobody tested it with the telnet program
> > > which prints the message.
> > 
> > There is no reason what so ever to _require_ that telnet message.
> 
> Yes, seems logical. Don't know why did Dave insist on matching
> that message. Is there anybody who can test this patch?

Need to patch away the EscapeChar definition above,
or we get unused warnings :-/

diff --git a/lib/plugins/stonith/apcmaster.c b/lib/plugins/stonith/apcmaster.c
--- a/lib/plugins/stonith/apcmaster.c
+++ b/lib/plugins/stonith/apcmaster.c
@@ -143,8 +143,6 @@ static const char * NOTpluginID = "APCMS
 
 #define APCMSSTR       "American Power Conversion"
 
-static struct Etoken EscapeChar[] =    { {"Escape character is '^]'.", 0, 0}
-                                       ,       {NULL,0,0}};
 static struct Etoken login[] =                 { {"User Name :", 0, 0}, 
{NULL,0,0}};
 static struct Etoken password[] =      { {"Password  :", 0, 0} ,{NULL,0,0}};
 static struct Etoken Prompt[] =        { {"> ", 0, 0} ,{NULL,0,0}};
@@ -183,8 +181,6 @@ static int  apcmaster_onoff(struct plugin
 static int
 MSLogin(struct pluginDevice * ms)
 {
-        EXPECT(ms->rdfd, EscapeChar, 10);
-
        /* 
         * We should be looking at something like this:
          *     User Name :

-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to