On Thu, Aug 14, 2025 at 05:07:11PM +0800, Chao Yu wrote: > This is a regression test: > 1. create a file > 2. write file to create a direct node at special offset > 3. use inject.f2fs to inject nid of direct node w/ ino of the inode > 4. check whether f2fs kernel module will detect and report such > corruption in the fil > > Cc: Jaegeuk Kim <jaeg...@kernel.org> > Signed-off-by: Chao Yu <c...@kernel.org> > ---
This version looks good to me, thanks for this new test coverage :) Reviewed-by: Zorro Lang <zl...@redhat.com> > v2: > - use _require_scratch_nocheck instead of _require_scratch > - use $XFS_IO_PROG instead of xfs_io > - add comments for why exporting MKFS_OPTIONS="" > tests/f2fs/019 | 42 ++++++++++++++++++++++++++++++++++++++++++ > tests/f2fs/019.out | 2 ++ > 2 files changed, 44 insertions(+) > create mode 100755 tests/f2fs/019 > create mode 100644 tests/f2fs/019.out > > diff --git a/tests/f2fs/019 b/tests/f2fs/019 > new file mode 100755 > index 00000000..2307bd96 > --- /dev/null > +++ b/tests/f2fs/019 > @@ -0,0 +1,42 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2025 Chao Yu. All Rights Reserved. > +# > +# FS QA Test No. f2fs/019 > +# > +# This is a regression test: > +# 1. create a file > +# 2. write file to create a direct node at special offset > +# 3. use inject.f2fs to inject nid of direct node w/ ino of the inode > +# 4. check whether f2fs kernel module will detect and report such > +# corruption in the file > +# > +. ./common/preamble > +_begin_fstest auto quick rw > + > +_fixed_by_kernel_commit 77de19b6867f \ > + "f2fs: fix to avoid out-of-boundary access in dnode page" > + > +_require_scratch_nocheck > +_require_command "$F2FS_INJECT_PROG" inject.f2fs > + > +# remove all mkfs options to avoid layout change of on-disk inode > +export MKFS_OPTIONS="" > + > +testfile=$SCRATCH_MNT/testfile > + > +_scratch_mkfs >> $seqres.full > +_scratch_mount > + > +$XFS_IO_PROG -f -c "pwrite 3738M 1M" -c "fsync" $testfile >> $seqres.full > + > +_scratch_unmount > + > +$F2FS_INJECT_PROG --node --mb addr --nid 5 --idx 937 --val 4 $SCRATCH_DEV >> > $seqres.full > + > +_scratch_mount > +$XFS_IO_PROG -c "pread 3700M 40M" $testfile > +_scratch_unmount > + > +status=0 > +exit > diff --git a/tests/f2fs/019.out b/tests/f2fs/019.out > new file mode 100644 > index 00000000..2f7469e2 > --- /dev/null > +++ b/tests/f2fs/019.out > @@ -0,0 +1,2 @@ > +QA output created by 019 > +pread: Structure needs cleaning > -- > 2.49.0 > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
