Hi,
I'm maintainer of erofs-utils for Alpine linux, distribution which use
musl libc instead of glibc.
Building version 1.8.6 gives error:
------------------
Making all in contrib
make[2]: Entering directory
'/home/mps/aports/community/erofs-utils/src/erofs-utils-1.8.6/contrib'
cc -DHAVE_CONFIG_H -I. -I.. -DNDEBUG -Wall -I../include -Os
-fstack-clash-protection -Wformat -Werror=format-security -fno-plt -MT
stress-stress.o -MD -MP -MF .deps/stress-stress.Tpo -c -o stress-stress.o `test
-f 'stress.c' || echo './'`stress.c
stress.c: In function '__getdents_f':
stress.c:274:16: error: implicit declaration of function 'readdir64'; did you
mean 'readdir_r'? [-Wimplicit-function-declaration]
274 | while (readdir64(dir) != NULL)
| ^~~~~~~~~
| readdir_r
stress.c:274:31: warning: comparison between pointer and integer
274 | while (readdir64(dir) != NULL)
| ^~
stress.c: In function '__read_f':
stress.c:431:17: error: implicit declaration of function 'pread64'; did you
mean 'pread'? [-Wimplicit-function-declaration]
431 | nread = pread64(fe->fd, buf, len, off);
| ^~~~~~~
| pread
stress.c: In function 'read_f':
stress.c:480:15: error: implicit declaration of function 'lseek64'; did you
mean 'lseek'? [-Wimplicit-function-declaration]
480 | fsz = lseek64(fe->fd, 0, SEEK_END);
| ^~~~~~~
| lseek
make[2]: *** [Makefile:420: stress-stress.o] Error 1
make[2]: Leaving directory
'/home/mps/aports/community/erofs-utils/src/erofs-utils-1.8.6/contrib'
make[1]: *** [Makefile:447: all-recursive] Error 1
make[1]: Leaving directory
'/home/mps/aports/community/erofs-utils/src/erofs-utils-1.8.6'
make: *** [Makefile:379: all] Error 2
>>> ERROR: erofs-utils: build failed
>>> erofs-utils: Uninstalling dependencies...
(1/19) Purging .makedepends-erofs-utils (20250506.063719)
------------------
This is because musl use readdir, pread and lseek instead of readdir64,
pread64 and lseek64.
(IMO musl does this properly)
Natanael Copa <nc...@alpinelinux.org> created patch with which I build
erofs-utils successfully. I'm attaching patch to this mail.
Feel free to contact me if you more information or to try some new
patches.
--
Kind regards
diff --git a/contrib/stress.c b/contrib/stress.c
index d8def6a..0593d71 100644
--- a/contrib/stress.c
+++ b/contrib/stress.c
@@ -271,7 +271,7 @@ static int __getdents_f(unsigned int sn, struct fent *fe)
}
dir = fdopendir(dfd);
- while (readdir64(dir) != NULL)
+ while (readdir(dir) != NULL)
continue;
closedir(dir);
return 0;
@@ -428,7 +428,7 @@ static int __read_f(unsigned int sn, struct fent *fe, uint64_t filesize)
printf("%d[%u]/%u read_f: %llu bytes @ %llu of %s\n", getpid(), procid,
sn, len | 0ULL, off | 0ULL, fe->subpath);
- nread = pread64(fe->fd, buf, len, off);
+ nread = pread(fe->fd, buf, len, off);
if (nread != trimmed) {
fprintf(stderr, "%d[%u]/%u read_f: failed to read %llu bytes @ %llu of %s\n",
getpid(), procid, sn, len | 0ULL, off | 0ULL,
@@ -439,7 +439,7 @@ static int __read_f(unsigned int sn, struct fent *fe, uint64_t filesize)
if (fe->chkfd < 0)
return 0;
- nread2 = pread64(fe->chkfd, chkbuf, len, off);
+ nread2 = pread(fe->chkfd, chkbuf, len, off);
if (nread2 <= 0) {
fprintf(stderr, "%d[%u]/%u read_f: failed to check %llu bytes @ %llu of %s\n",
getpid(), procid, sn, len | 0ULL, off | 0ULL,
@@ -477,14 +477,14 @@ static int read_f(int op, unsigned int sn)
if (ret)
return ret;
- fsz = lseek64(fe->fd, 0, SEEK_END);
+ fsz = lseek(fe->fd, 0, SEEK_END);
if (fsz <= 0) {
if (!fsz) {
printf("%d[%u]/%u %s: zero size @ %s\n",
getpid(), procid, sn, __func__, fe->subpath);
return 0;
}
- fprintf(stderr, "%d[%u]/%u %s: lseek64 %s failed %d\n",
+ fprintf(stderr, "%d[%u]/%u %s: lseek %s failed %d\n",
getpid(), procid, sn, __func__, fe->subpath, errno);
return -errno;
}
@@ -504,7 +504,7 @@ static int __doscan_f(unsigned int sn, const char *op, struct fent *fe,
for (pos = 0; pos < filesize; pos += chunksize) {
ssize_t nread, nread2;
- nread = pread64(fe->fd, buf, chunksize, pos);
+ nread = pread(fe->fd, buf, chunksize, pos);
if (nread <= 0)
return -errno;
@@ -515,7 +515,7 @@ static int __doscan_f(unsigned int sn, const char *op, struct fent *fe,
if (fe->chkfd < 0)
continue;
- nread2 = pread64(fe->chkfd, chkbuf, chunksize, pos);
+ nread2 = pread(fe->chkfd, chkbuf, chunksize, pos);
if (nread2 <= 0)
return -errno;
@@ -547,14 +547,14 @@ static int doscan_f(int op, unsigned int sn)
if (ret)
return ret;
- fsz = lseek64(fe->fd, 0, SEEK_END);
+ fsz = lseek(fe->fd, 0, SEEK_END);
if (fsz <= 0) {
if (!fsz) {
printf("%d[%u]/%u %s: zero size @ %s\n",
getpid(), procid, sn, __func__, fe->subpath);
return 0;
}
- fprintf(stderr, "%d[%u]/%u %s: lseek64 %s failed %d\n",
+ fprintf(stderr, "%d[%u]/%u %s: lseek %s failed %d\n",
getpid(), procid, sn, __func__, fe->subpath, errno);
return -errno;
}
@@ -576,7 +576,7 @@ static int doscan_aligned_f(int op, unsigned int sn)
ret = tryopen(sn, __func__, fe);
if (ret)
return ret;
- fsz = lseek64(fe->fd, 0, SEEK_END);
+ fsz = lseek(fe->fd, 0, SEEK_END);
if (fsz <= psz) {
if (fsz >= 0) {
printf("%d[%u]/%u %s: size too small %lld @ %s\n",
@@ -584,7 +584,7 @@ static int doscan_aligned_f(int op, unsigned int sn)
fe->subpath);
return 0;
}
- fprintf(stderr, "%d[%u]/%u %s: lseek64 %s failed %d\n",
+ fprintf(stderr, "%d[%u]/%u %s: lseek %s failed %d\n",
getpid(), procid, sn, __func__, fe->subpath, errno);
return -errno;
}
