On Mon, Apr 28, 2025 at 02:26:31PM +0000, Hongbo Li wrote: > Opt_err is not used in EROFS, we can remove it. > > Signed-off-by: Hongbo Li <lihongb...@huawei.com> > --- > fs/erofs/super.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index c1c350c6fbf4..fd365a611f13 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -356,8 +356,7 @@ static void erofs_default_options(struct erofs_sb_info > *sbi) > > enum { > Opt_user_xattr, Opt_acl, Opt_cache_strategy, Opt_dax, Opt_dax_enum, > - Opt_device, Opt_fsid, Opt_domain_id, Opt_directio, > - Opt_err > + Opt_device, Opt_fsid, Opt_domain_id, Opt_directio
We'd better to leave the trailing ',' so that we don't need to change this line again if a new line is introduced. Otherwise LGTM. Thanks, Gao Xiang > }; > > static const struct constant_table erofs_param_cache_strategy[] = { > -- > 2.22.0 >