Re: [PATCH 01/12] cachefiles: remove request from xarry during flush requests

[Jia Zhu via Linux-erofs]

在 2024/4/24 11:39, libao...@huaweicloud.com 写道:

From: Baokun Li <libaok...@huawei.com>

This prevents concurrency from causing access to a freed req.

Signed-off-by: Baokun Li <libaok...@huawei.com>

Reviewed-by: Jia Zhu <zhujia...@bytedance.com>

---
  fs/cachefiles/daemon.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c
index 6465e2574230..ccb7b707ea4b 100644
--- a/fs/cachefiles/daemon.c
+++ b/fs/cachefiles/daemon.c
@@ -159,6 +159,7 @@ static void cachefiles_flush_reqs(struct cachefiles_cache 
*cache)
        xa_for_each(xa, index, req) {
                req->error = -EIO;
                complete(&req->done);
+               __xa_erase(xa, index);
        }
        xa_unlock(xa);