On Fri, Apr 12, 2024 at 5:09 PM Gao Xiang <hsiang...@linux.alibaba.com> wrote: > > Hi Sandeep, > > On 2024/4/13 06:51, Sandeep Dhavale wrote: > > mkfs.erofs supports creating filesystem images with different > > blocksizes. Add filesystem blocksize in super block dump so > > its easier to inspect the filesystem. > > > > The filed is added at last, so the output now looks like: > > > > Filesystem magic number: 0xE0F5E1E2 > > Filesystem blocks: 21 > > Filesystem inode metadata start block: 0 > > Filesystem shared xattr metadata start block: 0 > > Filesystem root nid: 36 > > Filesystem lz4_max_distance: 65535 > > Filesystem sb_extslots: 0 > > Filesystem inode count: 10 > > Filesystem created: Fri Apr 12 15:43:40 2024 > > Filesystem features: sb_csum mtime 0padding > > Filesystem UUID: > > a84a2acc-08d8-4b72-8b8c-b811a815fa07 > > Filesystem blocksize: 65536 > > > > Signed-off-by: Sandeep Dhavale <dhav...@google.com> > > Just a minor nit: > Could we move "Filesystem blocksize:" between the line of > "Filesystem magic number:" and "Filesystem blocks:" ? > > Otherwise it looks good to me, thanks for this! > Hi Gao, Sure I can change the location. I didn't do it assuming someone might have scripted around it (not that I know of!), so I added it last. I will send V2 by moving it after magic number.
Thanks, Sandeep. > Thanks, > Gao Xiang
