On Wed, 17 Oct 2007, Oliver Endriss wrote:
> since there was no reply on the DVB ML:
> Is anyone maintaining the DVB part of the saa7134 driver?
> Can this patch be accepted?
It has a few problems:
Is there no sub-system data for this board? It should be added to
saa7134_pci_tbl
#include "isl6421.h"
+#include "tua6100.h"
+#include "stv0299.h"
Why is tua6100.h included when it's not used?
+
+static int philips_su1278_ty_ci_tuner_set_params(struct dvb_frontend *fe,
+ struct dvb_frontend_parameters
*params)
+{
This looks like code for a perfectly normal i2c pll tuner. Add it to dvb-pll
and use that driver.
+
+static struct stv0299_config lifeview = {
Make this const
+ case SAA7134_BOARD_LIFEVIEW_DVBS:
+ dev->dvb.frontend = dvb_attach(stv0299_attach, &lifeview,
+ &dev->i2c_adap);
+ if (dev->dvb.frontend) {
+ dev->dvb.frontend->ops.tuner_ops.set_params =
+ philips_su1278_ty_ci_tuner_set_params;
+#if 0
+ if (dvb_attach(tua6100_attach, dev->dvb.frontend, 0x61,
+ &dev->i2c_adap) == NULL) {
+ printk("%s: No tua6100 found!\n", __FUNCTION__);
+ }
+#endif
What's the #if 0 stuff for?
diff -ur v4l-dvb-ea93c93f1547-orig/linux/drivers/media/video/saa7134/saa7134.h
v4l-dvb-ea93c93f1547/linux/drivers/media/video/saa7134/saa7134.h
--- v4l-dvb-ea93c93f1547-orig/linux/drivers/media/video/saa7134/saa7134.h
2007-10-11 14:09:06.000000000 +0200
+++ v4l-dvb-ea93c93f1547/linux/drivers/media/video/saa7134/saa7134.h
2007-10-14 17:48:49.000000000 +0200
@@ -247,6 +247,7 @@
#define SAA7134_BOARD_SABRENT_TV_PCB05 115
#define SAA7134_BOARD_10MOONSTVMASTER3 116
#define SAA7134_BOARD_AVERMEDIA_SUPER_007 117
+#define SAA7134_BOARD_LIFEVIEW_DVBS 128
118 comes after 117
_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
