On 2026-07-14 17:47:35-07:00, Jacob Keller wrote: > On 7/13/2026 7:03 PM, Arthur Kiyanovski wrote: > > > Implement the gettimexattrs64 callback in the ENA driver to support > > the PTP_SYS_OFFSET_EXTENDED_ATTRS ioctl. > > > > This enables applications to retrieve PHC timestamps with quality > > attributes through the standard PTP ioctl interface. > > > > The ENA device currently reports only error_bound (valid bit set). > > Other attributes are not reported (valid bits unset). > > Typically it would be a policy not to introduce new attributes which are > not yet used, and add the other attributes once a user appears. However, > I think it makes sense to have the full set of desired attributes > especially given the ioctl interface limitations which would otherwise > require a lot of reserved space or new ioctl numbers. Especially given > the uAPI here has been discussed and changed heavily from previous patch > iterations.
Thanks — that matches the reasoning. We defined the full attribute set up front because of the ioctl interface constraints you describe. The valid bitmask ensures that userspace only consumes attributes that a driver explicitly reports, while still allowing additional attributes to become available in future drivers without further UAPI changes.
