On Mon, Feb 17, 2025 at 7:54 AM Usama Arif <usamaarif...@gmail.com> wrote: > > > > On 11/02/2025 00:40, Nico Pache wrote: > > This series is a follow-up to [1], which adds mTHP support to khugepaged. > > mTHP khugepaged support was necessary for the global="defer" and > > mTHP="inherit" case (and others) to make sense. > > > > Hi Nico, > > Thanks for the patches! Hi Usama,
Thank you for the review! > > Why is mTHP khugepaged a prerequisite for THP=defer? > THP=defer applies to PMD hugepages as well, so they should be independent. Its not a hard prerequisite, but I explained it a little here: https://lore.kernel.org/lkml/caa1cxcbpt4jhfh0ggio5ghsyaqaxf08ro8r6b1fahzdjff_...@mail.gmail.com/ In general, the sysfs didnt really make sense without it, and given mTHPs came along right when i was working on defer, I decided to add it to mTHP too. I worked on and tested these together so it felt right to sync up the V2s for both of them. Cheers, -- Nico > > >
