On Tue, Dec 03, 2024 at 12:39:21PM +0000, Mark Brown wrote: > DDI0601 2024-09 defines several new feature flags in ID_AA64ISAR3_EL1, > update our description in sysreg to reflect these. > > Signed-off-by: Mark Brown <broo...@kernel.org> > --- > arch/arm64/tools/sysreg | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index > 911f16c82ebd3ee98ffed965b02a5c6b153bc50c..c5af604eda6a721cedf5c9c68d6f7038156de651 > 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -1566,7 +1566,23 @@ EndEnum > EndSysreg > > Sysreg ID_AA64ISAR3_EL1 3 0 0 6 3 > -Res0 63:16 > +Res0 63:32 > +UnsignedEnum 31:28 FPRCVT > + 0b0000 NI > + 0b0010 IMP > +EndEnum > +UnsignedEnum 27:24 LSUI > + 0b0000 NI > + 0b0010 IMP > +EndEnum > +UnsignedEnum 23:20 OCCMO > + 0b0000 NI > + 0b0010 IMP > +EndEnum > +UnsignedEnum 19:16 LSFE > + 0b0000 NI > + 0b0010 IMP
These IMP encodings look wrong to me -- the document you reference in the commit message uses 0b0001 for the "implemented" cases. Can we _please_ just generate this stuff. It feels like we've been making silly typos over and over again with the current approach so either it's hard or we're not very good at it. Either way, it should be automated. Others have managed it [1], so it's clearly do-able. Will [1] https://github.com/ashwio/arm64-sysreg-lib
