Hello, Joel.

On Sun, Aug 11, 2019 at 06:11:09PM -0400, Joel Fernandes (Google) wrote:
> list_for_each_entry_rcu now has support to check for RCU reader sections
> as well as lock. Just use the support in it, instead of explicitly
> checking in the caller.
> 
> Signed-off-by: Joel Fernandes (Google) <j...@joelfernandes.org>

Acked-by: Tejun Heo <t...@kernel.org>

>  #define for_each_pwq(pwq, wq)                                                
> \
> -     list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node)          \
> -             if (({ assert_rcu_or_wq_mutex(wq); false; })) { }       \
> -             else
> +     list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node,          \
> +                              lock_is_held(&(wq->mutex).dep_map))

Why not lockdep_is_held() tho?

Thanks.

-- 
tejun

Reply via email to