Re: [PATCH v4 08/12] fpga: dfl: make uinit callback optional

[Moritz Fischer]

On Sun, Aug 04, 2019 at 06:20:18PM +0800, Wu Hao wrote:
> This patch makes uinit callback of sub features optional. With
> this change, people don't need to prepare any empty uinit callback.
> 
> Signed-off-by: Wu Hao <hao...@intel.com>
Acked-by: Moritz Fischer <m...@kernel.org>
> ---
>  drivers/fpga/dfl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> index 87eaef6..c0512af 100644
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -259,7 +259,8 @@ void dfl_fpga_dev_feature_uinit(struct platform_device 
> *pdev)
>  
>       dfl_fpga_dev_for_each_feature(pdata, feature)
>               if (feature->ops) {
> -                     feature->ops->uinit(pdev, feature);
> +                     if (feature->ops->uinit)
> +                             feature->ops->uinit(pdev, feature);
>                       feature->ops = NULL;
>               }
>  }
> -- 
> 1.8.3.1
>