On 2019-8-2 21:26, Jonathan Corbet wrote: > On Fri, 2 Aug 2019 09:21:35 +0800 > Chao Yu <yuch...@huawei.com> wrote: > >> Add entry to connect all Jaegeuk's email addresses. >> >> Acked-by: Jaegeuk Kim <jaeg...@kernel.org> >> Signed-off-by: Chao Yu <yuch...@huawei.com> >> --- >> .mailmap | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/.mailmap b/.mailmap >> index 477debe3d960..70d41c86e644 100644 >> --- a/.mailmap >> +++ b/.mailmap >> @@ -89,6 +89,9 @@ Henrik Kretzschmar <he...@nachtwindheim.de> >> Henrik Rydberg <rydb...@bitmath.org> >> Herbert Xu <herb...@gondor.apana.org.au> >> Jacob Shin <jacob.s...@amd.com> >> +Jaegeuk Kim <jaeg...@kernel.org> <jaeg...@google.com> >> +Jaegeuk Kim <jaeg...@kernel.org> <jaeg...@motorola.com> >> +Jaegeuk Kim <jaeg...@kernel.org> <jaegeuk....@samsung.com> > > So as I understand it, the mailmap file is there mostly to ensure that a > person's changesets are properly collected in 'git shortlog' and such. As > documented on the man page, it is used when a person's name is spelled > differently at different times. > > That doesn't appear to be the case here, and shortlog output is correct > already. Given that, do we *really* need to maintain a collection of old > email addresses in the mailmap file? What is the benefit of that?
IMO, when we use git-blame to find out who is response for specified code, w/o mailmap we may just found old obsolete email address in the related commit; even we can search full name for his/her new email address, how can we make sure they are the same person... so anyway, it can help to find last valid/canonical email address of someone. Thanks, > > Thanks, > > jon >
