On Fri, 11 Jan 2019 00:13:09 +0100
Christian Brauner <christ...@brauner.io> wrote:

> This documents the Android binderfs filesystem used to dynamically add and
> remove binder devices that are private to each instance.
> 
> Signed-off-by: Christian Brauner <christian.brau...@ubuntu.com>

Seems like a worthwhile addition overall.  I know nothing about binderfs,
so can't speak to the accuracy, of course.  I do have a couple of
metacomments, though:

 - Please consider doing this in RST and tying it into our documentation
   tree.  It's *almost* RST now, so the effort required will be almost
   zero.

 - It should probably have an SPDX line at the top.

 - Is it worth putting the example program in the samples/ directory?  Is
   it something that would ever make any sense to run in its current form?

Thanks,

jon

Reply via email to