> -----Original Message----- > From: Borislav Petkov <b...@alien8.de> > Sent: Tuesday, November 20, 2018 6:05 AM > To: Moger, Babu <babu.mo...@amd.com> > Cc: t...@linutronix.de; mi...@redhat.com; cor...@lwn.net; > fenghua...@intel.com; reinette.cha...@intel.com; pet...@infradead.org; > gre...@linuxfoundation.org; da...@davemloft.net; akpm@linux- > foundation.org; h...@zytor.com; x...@kernel.org; > mchehab+sams...@kernel.org; a...@arndb.de; > kstew...@linuxfoundation.org; pombreda...@nexb.com; > raf...@kernel.org; kirill.shute...@linux.intel.com; tony.l...@intel.com; > qianyue...@alibaba-inc.com; xiaochen.s...@intel.com; > pbonz...@redhat.com; Singh, Brijesh <brijesh.si...@amd.com>; Hurwitz, > Sherry <sherry.hurw...@amd.com>; dw...@infradead.org; Lendacky, > Thomas <thomas.lenda...@amd.com>; l...@kernel.org; j...@8bytes.org; > ja...@google.com; vkuzn...@redhat.com; r...@alum.mit.edu; > jpoim...@redhat.com; linux-ker...@vger.kernel.org; linux- > d...@vger.kernel.org > Subject: Re: [PATCH v8 06/13] arch/resctrl: Initialize the resource functions > that are different > > On Tue, Nov 20, 2018 at 10:59:18AM +0100, Borislav Petkov wrote: > > So I'm wondering: instead of having mba_wrmsr_intel() and > > mba_wrmsr_amd() and adding those per-vendor initialization functions, > > why don't you push down the vendor differentiation into mba_wrmsr()? > > > > Then in that function you do > > > > if (vendor == X86_VENDOR_INTEL) > > __mba_wrmsr_intel(); > > else if (vendor == X86_VENDOR_AMD) > > __mba_wrmsr_amd(); > > > > and so on and then you don't have to do any of that initialization dance > > here and the struct rdt_resource assignment for the MBA will remain > > nicely similar to the other ones... > > > > Hmmm? > > Yeah, after having look at the patchset further, that might not be a > good idea as you need to assign more per-vendor stuff than just an MSR > accessor function...
Ok. No changes here. Thanks > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply.
