Hi Gilad,

On Sat, May 06, 2017 at 03:59:56PM +0300, Gilad Ben-Yossef wrote:
>  int fscrypt_do_page_crypto(const struct inode *inode, fscrypt_direction_t rw,
>                          u64 lblk_num, struct page *src_page,
>                          struct page *dest_page, unsigned int len,
> @@ -150,7 +135,7 @@ int fscrypt_do_page_crypto(const struct inode *inode, 
> fscrypt_direction_t rw,
>               u8 padding[FS_XTS_TWEAK_SIZE - sizeof(__le64)];
>       } xts_tweak;
>       struct skcipher_request *req = NULL;
> -     DECLARE_FS_COMPLETION_RESULT(ecr);
> +     DECLARE_CRYPTO_WAIT(ecr);
>       struct scatterlist dst, src;
>       struct fscrypt_info *ci = inode->i_crypt_info;
>       struct crypto_skcipher *tfm = ci->ci_ctfm;
> @@ -168,7 +153,7 @@ int fscrypt_do_page_crypto(const struct inode *inode, 
> fscrypt_direction_t rw,
[...]

This patch looks good --- thanks for doing this!  I suggest also renaming 'ecr'
to 'wait' in the places being updated to use crypto_wait, since the name is
obsolete (and was already; it originally stood for "ext4 completion result").

- Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to