On Tue, 31 Jan 2017, Ben Hutchings <[email protected]> wrote: > As we use redirection to create the SVG file, even a failed conversion > will create the file and 'make' will consider it up-to-date if the > build is retried. We should delete it in case of failure. > > Fixes: ec868e4ee2bc ("docs-rst: media: build SVG from graphviz files") > Signed-off-by: Ben Hutchings <[email protected]> > --- > Documentation/media/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/media/Makefile b/Documentation/media/Makefile > index 32663602ff25..730d73db7c7a 100644 > --- a/Documentation/media/Makefile > +++ b/Documentation/media/Makefile > @@ -36,7 +36,7 @@ quiet_cmd_genpdf = GENPDF $2 > cmd_genpdf = convert $2 $3 > > quiet_cmd_gendot = DOT $2 > - cmd_gendot = dot -Tsvg $2 > $3 > + cmd_gendot = dot -Tsvg $2 > $3 || { rm -f $3; exit 1; }
I'd just use dot -o. > > %.pdf: %.svg > @$(call cmd,genpdf,$<,$@) > -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
