Applied, thanks.
Huacai
On Mon, Feb 24, 2025 at 7:21 PM Xi Ruoyao <xry...@xry111.site> wrote:
>
> glibc added support for .gnu.hash in 2006 and .hash has been obsoleted
> far before the first LoongArch CPU was taped. Using
> --hash-style=sysv might imply unaddressed issues and confuse readers.
>
> Some architectures use an explicit --hash-style=both here, but
> DT_GNU_HASH has already been supported by Glibc and Musl and become the
> de-facto standard of the distros when the first LoongArch CPU was taped.
> So DT_HASH seems just wasting storage space for LoongArch.
>
> Just drop the option and rely on the linker default, which is likely
> "gnu" (Arch, Debian, Gentoo, LFS) on all LoongArch distros (confirmed on
> Arch, Debian, Gentoo, and LFS; AOSC now defaults to "both" but it seems
> just an oversight).
>
> Following the logic of commit 48f6430505c0
> ("arm64/vdso: Remove --hash-style=sysv").
>
> Link: https://github.com/AOSC-Dev/aosc-os-abbs/pull/9796
> Signed-off-by: Xi Ruoyao <xry...@xry111.site>
> ---
> arch/loongarch/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> index fdde1bcd4e26..abaf87c58f9d 100644
> --- a/arch/loongarch/vdso/Makefile
> +++ b/arch/loongarch/vdso/Makefile
> @@ -37,7 +37,7 @@ endif
> # VDSO linker flags.
> ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \
> - --hash-style=sysv --build-id -T
> + --build-id -T
>
> #
> # Shared build commands.
> --
> 2.48.1
>
