Warn about applications of capability_unsafe() without a comment, to
encourage documenting the reasoning behind why it was deemed safe.

Signed-off-by: Marco Elver <el...@google.com>
---
 scripts/checkpatch.pl | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7b28ad331742..c28efdb1d404 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6693,6 +6693,14 @@ sub process {
                        }
                }
 
+# check for capability_unsafe without a comment.
+               if ($line =~ /\bcapability_unsafe\b/) {
+                       if (!ctx_has_comment($first_line, $linenr)) {
+                               WARN("CAPABILITY_UNSAFE",
+                                    "capability_unsafe without comment\n" . 
$herecurr);
+                       }
+               }
+
 # check of hardware specific defines
                if ($line =~ 
m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ 
m@include/asm-@) {
                        CHK("ARCH_DEFINES",
-- 
2.48.1.711.g2feabab25a-goog


Reply via email to