On Fri, 28 Aug 2020 at 12:24, Giovanni Cabiddu <[email protected]> wrote: > > On Sat, Aug 22, 2020 at 02:04:10PM +0100, Ard Biesheuvel wrote: > > On Sat, 22 Aug 2020 at 09:29, Giovanni Cabiddu > > <[email protected]> wrote: > > > > > > From: Dominik Przychodni <[email protected]> > > > > > > Include an additional check on the cipher length to prevent undefined > > > behaviour from occurring upon submitting requests which are not a > > > multiple of AES_BLOCK_SIZE. > > > > > > Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface") > > > Signed-off-by: Dominik Przychodni <[email protected]> > > > Signed-off-by: Giovanni Cabiddu <[email protected]> > > > > I only looked at the patch, and not at the entire file, but could you > > explain which AES based AEAD implementations require the input length > > to be a multiple of the block size? CCM and GCM are both CTR based, > > and so any input length should be supported for at least those modes. > This is only for AES CBC as the qat driver supports only > authenc(hmac(sha1),cbc(aes)), authenc(hmac(sha256),cbc(aes)) and > authenc(hmac(sha512),cbc(aes)). >
Ah right, yes that makes sense.
