On 17.10.19 г. 5:38 ч., Qu Wenruo wrote:
> [BUG]
> For btrfs:qgroup_meta_reserve event, the trace event can output garbage:
> qgroup_meta_reserve: 9c7f6acc-b342-4037-bc47-7f6e4d2232d7: refroot=5(FS_TREE)
> type=DATA diff=2
> qgroup_meta_reserve: 9c7f6acc-b342-4037-bc47-7f6e4d2232d7: refroot=5(FS_TREE)
> type=0x258792 diff=2
>
> The @type can be completely garbage, as DATA type is not possible for
> trace_qgroup_meta_reserve() trace event.
>
> [CAUSE]
> Ther are several problems related to qgroup trace events:
> - Unassigned entry member
> Member entry::type of trace_qgroup_update_reserve() and
> trace_qgourp_meta_reserve() is not assigned
>
> - Redundant entry member
> Member entry::type is completely useless in
> trace_qgroup_meta_convert()
>
> [FIX]
> Fix these stupid bugs.
>
> Fixes: 4ee0d8832c2e ("btrfs: qgroup: Update trace events for metadata
> reservation")
> Signed-off-by: Qu Wenruo <[email protected]>
Reviewed-by: Nikolay Borisov <[email protected]>
