On Mon, Oct 07, 2019 at 04:17:46PM -0400, Dennis Zhou wrote: > Async discard doesn't remember the discard state of a block_group when > unmounting or when we crash. So, any block_group that is not fully used > may have undiscarded regions. However, free space caches are read in on > demand. Let the discard worker read in the free space cache so we can > proceed with discarding rather than wait for the block_group to be used. > This prevents us from indefinitely deferring discards until that > particular block_group is reused. > > Signed-off-by: Dennis Zhou <[email protected]>
What if we did completely discard the last time, now we're going back and discarding again? I think by default we just assume we discarded everything. If we didn't then the user can always initiate a fitrim later. Drop this one. Thanks, Josef
