On 27/08/2019 01:21, David Sterba wrote:
> On Mon, Aug 26, 2019 at 06:38:13PM +0300, Nikolay Borisov wrote:
>> nit: I'd name this commit "Add xxhash64 to supported checksum hashes"
>>
>> Personally, I interpret 'use <some hash> for checksumming' as if you are
>> modifying code to use that hash. But in fact you are not, at least not
>> in that patch.
>
> It could be percieved as nitpicking, but this kind of feedback is a
> check that the author's intentions are understood by someone else. Some
> subtleties or nuances can be missed by authors and this is maybe
> inevitable when one spends significant time on the code or changelog.
> The fresh look and first impression is not possible anymore. But this is
> how patches are read when found git log.
>
> In this case I agree with you and the use use of 'use' is a bit
> misleading, suggesting that xxhash is now default.
No problem. Dave are going to fix it up or do you want me to re-submit?
I don't really care either way.
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
[email protected] +49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 247165, AG München)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
