On Wed, Mar 20, 2019 at 07:53:18PM +0800, Qu Wenruo wrote: > >> +error: > >> + return -EUCLEAN; > >> +} > >> + > > > > Why aren't you directly returning -EUCLEAN instead of the gotos? There's > > no cleanup pending so the additional jump label is unnecessary. > > Just a coding preference. > > Will it impact the performance or compiler is clever enough to change > the goto line to return -EUCLEAN?
This is a matter of codingstyle, it should be consistent, so if one function uses return -EUCLEAN and another goto error:, then one of them has to be changed.
