It's no good to override error code when failing from btrfs_getxattr() in btrfs_get_acl() because it will hide real root cause.
Signed-off-by: Chengguang Xu <[email protected]> Reviewed-by: Nikolay Borisov <[email protected]> --- v4: - Split patch to series. v3: - Fix some toher bad practices. - Add more information to commit log. v2: - Avoid errno overriding instead of print error message in error case. - Chagne commit log for better understanding. fs/btrfs/acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c index a1d7211c8884..7d673ec9e54a 100644 --- a/fs/btrfs/acl.c +++ b/fs/btrfs/acl.c @@ -45,7 +45,7 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type) } else if (size == -ENODATA || size == 0) { acl = NULL; } else { - acl = ERR_PTR(-EIO); + acl = ERR_PTR(size); } kfree(value); -- 2.17.1 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
