On Fri, 09 Jan 2015 09:39:40 +0800, Gui Hecheng wrote:
> The xfstests btrfs/072 reports uncorrectable read errors in dmesg,
> because scrub forgets to use commit_root for parity scrub routine
> and scrub attempts to scrub those extents items whose contents are
> not fully on disk.
> 
> To fix it, we just add the @search_commit_root flag back.

Reviewed-by: Miao Xie <[email protected]>

> 
> Signed-off-by: Gui Hecheng <[email protected]>
> Signed-off-by: Qu Wenruo <[email protected]>
> ---
>  fs/btrfs/scrub.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
> index f2bb13a..aa8ff75 100644
> --- a/fs/btrfs/scrub.c
> +++ b/fs/btrfs/scrub.c
> @@ -3065,6 +3065,8 @@ static noinline_for_stack int scrub_stripe(struct 
> scrub_ctx *sctx,
>       path->search_commit_root = 1;
>       path->skip_locking = 1;
>  
> +     ppath->search_commit_root = 1;
> +     ppath->skip_locking = 1;
>       /*
>        * trigger the readahead for extent tree csum tree and wait for
>        * completion. During readahead, the scrub is officially paused
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to