Re: [PATCH v4 11/25] ibtrs: server: statistics functions

[Bart Van Assche]

On 6/20/19 8:03 AM, Jack Wang wrote:
+ssize_t ibtrs_srv_stats_rdma_to_str(struct ibtrs_srv_stats *stats,
+                                   char *page, size_t len)
+{
+       struct ibtrs_srv_stats_rdma_stats *r = &stats->rdma_stats;
+       struct ibtrs_srv_sess *sess;
+
+       sess = container_of(stats, typeof(*sess), stats);
+
+       return scnprintf(page, len, "%lld %lld %lld %lld %u\n",
+                        (s64)atomic64_read(&r->dir[READ].cnt),
+                        (s64)atomic64_read(&r->dir[READ].size_total),
+                        (s64)atomic64_read(&r->dir[WRITE].cnt),
+                        (s64)atomic64_read(&r->dir[WRITE].size_total),
+                        atomic_read(&sess->ids_inflight));
+}

Does this follow the sysfs one-value-per-file rule? See also 
Documentation/filesystems/sysfs.txt.

Thanks,

Bart.