An unsigned integer variable may be assigned negative values, and is returned by the function with an implicit conversion to signed. Besides the implicit conversion at return time for which the variable representation is fine and there is no variable manipulation that may lead to bugs in the current code base, this is a conceptual error.
Fix by changing the variable type from unsigned to signed. Signed-off-by: Alessio Balsini <[email protected]> Cc: Jens Axboe <[email protected]> --- block/blk-settings.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/blk-settings.c b/block/blk-settings.c index 6bd1e3b082d8..c76c25c45869 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -496,7 +496,8 @@ EXPORT_SYMBOL(blk_queue_stack_limits); int blk_stack_limits(struct queue_limits *t, struct queue_limits *b, sector_t start) { - unsigned int top, bottom, alignment, ret = 0; + unsigned int top, bottom, alignment; + int ret = 0; t->max_sectors = min_not_zero(t->max_sectors, b->max_sectors); t->max_hw_sectors = min_not_zero(t->max_hw_sectors, b->max_hw_sectors); -- 2.23.0.237.gc6a4ce50a0-goog
