On 9/16/19 2:06 AM, Christoph Hellwig wrote:
On Mon, Sep 16, 2019 at 07:46:29AM +0530, [email protected] wrote:
From: Xiubo Li <[email protected]>

To make the patch more readable and cleaner I just split them into 2
small ones to address the issue from @Ming Lei, thanks very much.

I'd be much happier to just see memalloc_noio_save +
memalloc_noio_restore calls in the right places over sprinkling even
more magic GFP_NOIO arguments.

Hi Christoph,

My understanding is that memalloc_noio_save() and memalloc_noio_restore() have been introduced to avoid having to pass flags that specify the noio context along deep call chains. Are you sure it helps to use these functions if no other function than kmalloc() is called between the memalloc_noio_save() and memalloc_noio_restore() calls?

Thanks,

Bart.

Reply via email to