Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

On 05/15/2019 02:04 AM, Jackie Liu wrote:
> Use the new struct_size() helper to keep code simple.
>
> Signed-off-by: Jackie Liu <[email protected]>
> ---
>   block/bio-integrity.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/bio-integrity.c b/block/bio-integrity.c
> index 1b633a3526d4..5152009b5b59 100644
> --- a/block/bio-integrity.c
> +++ b/block/bio-integrity.c
> @@ -57,8 +57,7 @@ struct bio_integrity_payload *bio_integrity_alloc(struct 
> bio *bio,
>       unsigned inline_vecs;
>
>       if (!bs || !mempool_initialized(&bs->bio_integrity_pool)) {
> -             bip = kmalloc(sizeof(struct bio_integrity_payload) +
> -                           sizeof(struct bio_vec) * nr_vecs, gfp_mask);
> +             bip = kmalloc(struct_size(bip, bip_inline_vecs, nr_vecs), 
> gfp_mask);
>               inline_vecs = nr_vecs;
>       } else {
>               bip = mempool_alloc(&bs->bio_integrity_pool, gfp_mask);
>

Reply via email to