Hi Vincent,
-------- Original Message --------
From: Vincent Guittot
Sent: Tue, 7 May 2019 09:00:49 +0200
To: 阮正旺
Cc: Luis Machado, Linaro-dev
Subject: Re: [PATCH PM-QA v2] Android.mk: fix compiling errors caused by
unused parameters
Hi Zhengwang,
On Tue, 7 May 2019 at 08:54, 阮正旺 <rua...@xiaopeng.com> wrote:
Hi Vincent, Lius,
How do you think about this patch? :-)
It looks good to me. I'm going to merge it
It's great! Thank you!
Kind Regards,
Zhengwang
Thanks
Vincent
Kind Regards,
Zhengwang
-------- Original Message --------
From: 阮正旺
Sent: Thu, 2 May 2019 15:49:04 +0800
To: Vincent Guittot, Luis Machado
Cc: Linaro-dev
Subject: Re: [PATCH PM-QA v2] Android.mk: fix compiling errors caused by unused
parameters
Hi Vincent,
This is version 2nd, please help review it again, thanks!
Kind Regards,
Zhengwang
-------- Original Message --------
From: Zhengwang Ruan
Sent: Thu, 2 May 2019 15:44:13 +0800
To: Vincent Guittot, Luis Machado
Cc: Linaro-dev, Zhengwang Ruan
Subject: [PATCH PM-QA v2] Android.mk: fix compiling errors caused by unused
parameters
Android enables '-Wall -Werror' compiling parameters by default, as a result
compiling errors are caused in cpuidle and utils, so add '-Wno-error' to disable
this check.
Signed-off-by: Zhengwang Ruan <rua...@xiaopeng.com>
---
cpuidle/Android.mk | 1 +
utils/Android.mk | 1 +
2 files changed, 2 insertions(+)
diff --git a/cpuidle/Android.mk b/cpuidle/Android.mk
index f0dc52d..041b7f6 100644
--- a/cpuidle/Android.mk
+++ b/cpuidle/Android.mk
@@ -23,6 +23,7 @@ LOCAL_MODULE := cpuidle_killer
systemtarball: cpuidle_killer
systemimage: cpuidle_killer
LOCAL_SRC_FILES:= cpuidle_killer.c
+LOCAL_CFLAGS += -Wno-error
LOCAL_SHARED_LIBRARIES := libcutils libc
LOCAL_MODULE_TAGS := tests
LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name)
diff --git a/utils/Android.mk b/utils/Android.mk
index 0fee7bf..6484bfc 100644
--- a/utils/Android.mk
+++ b/utils/Android.mk
@@ -11,6 +11,7 @@ define $(module_name)_etc_add_executable
systemtarball: $1
systemimage: $1
LOCAL_SRC_FILES := $1.c
+ LOCAL_CFLAGS += -Wno-error
LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES)/pm-qa/$(module_name)
include $(BUILD_EXECUTABLE)
endef
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/linaro-dev
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/linaro-dev
