On Mon, Feb 2, 2015 at 11:40 AM, Amit Kucheria <amit.kuche...@linaro.org> wrote: > Hi Lisa, > > On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen <lisa.ngu...@linaro.org> wrote: >> Changes in v2: >> - Reorganized previous patchset and recreated patches based on >> logical change >> - Rewritten logic to find certain attributes in sysfs >> >> [Let's try again...] > > Looks much better and easier to review. Still a few more things for > the perfect patchset though :) > > You've conflated several things into one big patch series - removal of > bashisms, bug fixes, better error handling, new features. > > Patches 1-12 seem to contain all the bashism removal. Let us get those > merged first after you've run them through git test-sequence[1]. > This'll make sure that the change from /bin/bash to /bin/sh in the > first patch won't break the intermediate state of the tree. Each patch > should be atomic. > > [1] http://dustin.sallings.org/2010/03/28/git-test-sequence.html
To be perfectly clear, please feel free to add my reviewed-by to 1-12 after you do two things: 1. Run them through git test-sequence 2. Minor fix in 9 _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
