Hi Jon, On 04/17/2013 06:29 AM, Jon Medhurst (Tixy) wrote: > On Wed, 2013-04-17 at 06:21 +0200, Jonathan Aquilina wrote: >> Doesnt email run the risk of a patch slipping through the cracks? > > And with gerrit the patch author needs to get an account enabled with the > project, produce a git commit against the current tip,
I can't recall ever seeing an upload refused because it wasn't against the latest commit. What's the error message you get? Or is it possible that you might be misremembering such an incident? > know who to pick as reviewers then rely on the people they pick to > actually review the patch I fail to see how emailing patches approaches this problem any differently. > then rebase and resubmit the patch because the tip has moved during the > review process Perhaps it is a small fault of the software that the configuration doesn't default to an easier-going merge method such as cherry picking. It's really easy to change, though. Admin->Projects->NAME->Project Options->Cherry Pick. It seems like emailed patches have their fair share of merge conflicts. > and then have someone with commit rights accept it. I fail to see how emailing patches approaches this problem any differently. > And the web interface is horrible. What's your preferred intraline diff application? > You may have guessed I'm not a fan ;-) I don't necessarily think Linaro needs more Gerrit, but I would hate to see misunderstandings about software that's been good to me go uncorrected. Cheers, Christopher -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation. _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
