Hi Tixy, On Wed, Jan 09, 2013 at 05:04:38PM +0000, Jon Medhurst (Tixy) wrote: > Patch 25c92a37a (arm64: Always select ARM_AMBA and GENERIC_GPIO) > expects platforms to have GPIO so we need to make sure vexpress > always has this by selecting ARCH_REQUIRE_GPIOLIB. > > Without this change drivers like MMC fail to compile due to missing > gpio definitions like: > > In file included from include/linux/gpio.h:48:0, > from drivers/mmc/core/slot-gpio.c:12: > include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep': > include/asm-generic/gpio.h:235:2: error: implicit declaration of function > '__gpio_get_value' > > Signed-off-by: Jon Medhurst <t...@linaro.org> > --- > > Hi Catalin, not sure if this is the correct fix, but it works and > matches 32-bit vexpress. > > arch/arm64/platforms/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/platforms/Kconfig b/arch/arm64/platforms/Kconfig > index d2fc931..26d1d14 100644 > --- a/arch/arm64/platforms/Kconfig > +++ b/arch/arm64/platforms/Kconfig > @@ -1,6 +1,6 @@ > config PLAT_VEXPRESS > bool "ARMv8 software model (Versatile Express)" > - select ARCH_WANT_OPTIONAL_GPIOLIB > + select ARCH_REQUIRE_GPIOLIB > select ARM_AMBA > select CLKDEV_LOOKUP > select ARM_GIC
The latest incarnation of soc-armv8-model branch has this already (maybe I got to the same conclusion or just folded your patch, I don't remember). The only difference is that it's called ARCH_VEXPRESS to match the AArch32 code (and Pawel's vexpress support under drivers/). Thanks. -- Catalin _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
