On Tue, 2012-10-09 at 11:42 +0100, Sudeep KarkadaNagesha wrote: > On 09/10/12 11:33, Amit Kucheria wrote: > > On Tue, Oct 9, 2012 at 2:13 PM, Jon Medhurst (Tixy) <t...@linaro.org> wrote: > >> On Tue, 2012-10-09 at 09:27 +0100, Sudeep KarkadaNagesha wrote: > >>> On 09/10/12 08:10, Viresh Kumar wrote: > >>>> Following is the declaration of name field in struct cpufreq_driver: > >>>> char name[CPUFREQ_NAME_LEN]; > >>>> > >>>> where CPUFREQ_NAME_LEN is 16. > >>>> > >>>> So, length of drivers name must be <=15 (one position for '\0'). > >>>> Current name is crossing this limit and so name doesn't get printed > >>>> properly > >>>> when we do: > >>>> > >>>> $ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver > >>>> > >>>> This patch renames driver-name to fix this issue. > >>>> > >>>> Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> > >>> Acked-by: Sudeep KarkadaNagesha <sudeep.karkadanage...@arm.com> > >> > >> Shall I apply this to the ARM Landing Team vexpress tree then? > > > > I'd say yes, the driver lives in your tree. I'm not sure how you > > coordinate the code drops with ARM since it should be in their tree as > > well for the future. > > > Robin raised a valid point that this driver is TC2 specific and bL is > not appropriate name for it including the file name(my bad choice at first).
Considering the confusion over what the correct naming should be, I don't think it's worth me apply the renaming patch at the moment ;-) -- Tixy _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
