Minor comments here :)
On 22 September 2012 00:02, <morten.rasmus...@arm.com> wrote:
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d80de46..490f1f0 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3744,7 +3744,6 @@ int can_migrate_task(struct task_struct *p, struct
> lb_env *env)
> * 1) task is cache cold, or
> * 2) too many balance attempts have failed.
> */
> -
:(
> tsk_cache_hot = task_hot(p, env->src_rq->clock_task, env->sd);
> if (!tsk_cache_hot ||
> env->sd->nr_balance_failed > env->sd->cache_nice_tries) {
> @@ -5516,6 +5515,199 @@ static unsigned int hmp_down_migration(int cpu,
> struct sched_entity *se)
> return 0;
> }
>
> +static int hmp_can_migrate_task(struct task_struct *p, struct lb_env *env)
> +{
<...>
> +static int move_specific_task(struct lb_env *env, struct task_struct *pm)
> +{
> + struct task_struct *p, *n;
> +
> + list_for_each_entry_safe(p, n, &env->src_rq->cfs_tasks,
> se.group_node) {
> + if (throttled_lb_pair(task_group(p), env->src_rq->cpu,
> + env->dst_cpu))
> + continue;
Please fix indentation of above if statement.
<...>
> +#else
> +static void hmp_force_up_migration(int this_cpu) { }
inline?
--
viresh
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
