On Mon, Apr 16, 2012 at 06:37:48PM -0500, Robert Lee wrote: > The imx5_idle() check of the tzic_eanble_wake() return value uses > incorrect (inverted) logic causing all attempt to idle to fail. >
Does this have influence on current kernels or does this only trigger with your cpuidle patches? Sascha > Signed-off-by: Robert Lee <rob....@linaro.org> > --- > arch/arm/mach-imx/mm-imx5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-imx/mm-imx5.c b/arch/arm/mach-imx/mm-imx5.c > index 05250ae..e10f391 100644 > --- a/arch/arm/mach-imx/mm-imx5.c > +++ b/arch/arm/mach-imx/mm-imx5.c > @@ -35,7 +35,7 @@ static void imx5_idle(void) > } > clk_enable(gpc_dvfs_clk); > mx5_cpu_lp_set(WAIT_UNCLOCKED_POWER_OFF); > - if (tzic_enable_wake() != 0) > + if (!tzic_enable_wake()) > cpu_do_idle(); > clk_disable(gpc_dvfs_clk); > } > -- > 1.7.10 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev