On Thu, Mar 01, 2012 at 05:10:52PM +0800, Ying-Chun Liu (PaulLiu) wrote:
> + if (IS_ERR(rdev)) {
> + dev_err(&pdev->dev, "failed to register %s\n",
> + rdesc->name);
> + kfree(rdesc->name);
> + return PTR_ERR(rdev);
> + }
> +
> + return 0;
> +}
> +
> +int anatop_regulator_remove(struct platform_device *pdev)
> +{
> + struct regulator_dev *rdev = platform_get_drvdata(pdev);
> + regulator_unregister(rdev);
> + return 0;Looks mostly good but this leaks rdesc->name which was allocated with kstrdup() in the probe() function.
signature.asc
Description: Digital signature
_______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
