On 21 February 2012 16:37, Kukjin Kim <kgene....@samsung.com> wrote: > Amit Kachhap wrote: >> >> Hi kukjin Kim, >> > Hi, > >> I was on travel for elc and linaro conferences so little late for >> replying. Thanks for testing these patches. >> I just submitted the V6 series of the cpuidle patchset. I rebased it >> against the 3.3-rc4 kernel version. I also tested it for SMDKV310 >> (evt1) and Origen (evt1.1) boards and they are working fine. >> Some modification was done for CHECK_FLAG. >> > > OK, I checked it works fine on SMDKV310 now. > As I said, will apply your patches for v3.4 but I'm not sure there is a > problem with common cpuidle work.
These patches could be part of your for-next branch (and available for v3.4 merge) and any work on common cpuidle code would be incremental changes to this patchset. Regards, Amit Daniel > > Anyway, good job. > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene....@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > >> Thanks, >> Amit Daniel >> >> >> On 18 February 2012 07:29, Kukjin Kim <kgene....@samsung.com> wrote: >> > Amit Kachhap wrote: >> >> >> >> Hi Amit Kucheria, >> >> >> > Hi all, >> > >> > (Cc'ed Jaecheol Lee and Jongpill Lee) >> > >> >> I have asked the samsung maintainer(Kukjin Kim) to queue this patch set >> 1 >> >> month back. But seems like it is not present. >> >> >> > >> > If it works fine, then I'm apply this series. >> > >> > But now it is not working. As a note, I use your series on top of v3.3- >> rc3 >> > and fixed following for test. >> > >> > arch/arm/mach-exynos/cpuidle.c: In function 'exynos4_enter_core0_aftr': >> > arch/arm/mach-exynos/cpuidle.c:119: error: implicit declaration of >> function >> > 'BSYM' >> > make[1]: *** [arch/arm/mach-exynos/cpuidle.o] Error 1 >> > >> > I and Jaecheol Lee tested AFTR mode on SMDKV310 and SMDKC210 and then >> > rebooting happened. >> > See below log. >> > >> > If any updates, please let me know. >> > >> > --- >> > >> > Booting Linux on physical CPU 0 >> > Linux version 3.3.0-rc3-00005-g20ea355-dirty (kgene@starstone) (gcc >> version >> > 4.4.1 (Sourcery G++ Lite 2009q3-67) ) #2 SMP PREEMPT Sat Feb 18 09:15:42 >> KST >> > 2012 >> > CPU: ARMv7 Processor [412fc091] revision 1 (ARMv7), cr=10c5387d >> > CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache >> > Machine: SMDKV310 >> > Memory policy: ECC disabled, Data cache writealloc >> > CPU EXYNOS4210 (id 0x43210010) >> > >> > [snip] >> > >> > [root@Samsung ~]# cd /sys/devices/system/cpu/cpu0/cpuidle/ >> > [root@Samsung cpuidle]# ls >> > state0/ state1/ >> > [root@Samsung cpuidle]# cd state1 >> > [root@Samsung state1]# ls >> > desc latency name power time usage >> > [root@Samsung state1]# cat name >> > C1 >> > [root@Samsung state1]# cat time >> > 0 >> > [root@Samsung state1]# echo 0 > /sys/devices/system/cpu/cpu1/online >> > CPU1: shutdown >> > [root@Samsung state1]# ðK >> > >> > U-Boot 2010.12-00009-g300b392 (Jul 15 2011 - 16:39:20) for SMDKV310 >> > ... >> > >> > [snip] >> > >> > Starting kernel ... >> > >> > Uncompressing Linux... done, booting the kernel. >> > Booting Linux on physical CPU 0 >> > Linux version 3.3.0-rc3-00005-g20ea355-dirty (kgene@starstone) (gcc >> version >> > 4.4.1 (Sourcery G++ Lite 2009q3-67) ) #2 SMP PREEMPT Sat Feb 18 09:15:42 >> KST >> > 2012 >> > CPU: ARMv7 Processor [412fc091] revision 1 (ARMv7), cr=10c5387d >> > CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache >> > Machine: SMDKC210 >> > >> > [snip] >> > >> > Samsung SMDK Board on a armv7l >> > Samsung login: root >> > login[1002]: root login on 'ttySAC1' >> > [root@Samsung ~]# >> > [root@Samsung ~]# >> > [root@Samsung ~]# >> > [root@Samsung ~]# >> > [root@Samsung ~]# echo 0 > /sys/devices/system/cpu/cpu1/online >> > CPU1: shutdown >> > [root@Samsung ~]# O >> > >> > [snip] (as a note, the mark of 'O' means 'OK' printing from u-boot. >> > >> > Thanks. >> > >> > Best regards, >> > Kgene. >> > -- >> > Kukjin Kim <kgene....@samsung.com>, Senior Engineer, >> > SW Solution Development Team, Samsung Electronics Co., Ltd. >> > >> > >> > >> >> >> >> Hi Mr Kim, >> >> >> >> Can you please queue this patchset in your tree for next merge window? >> >> The V5 version submitted fixes all the known issues. >> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2012- >> >> January/079214.html >> >> >> >> Thanks, >> >> Amit Daniel >> >> >> >> >> >> On 17 February 2012 11:42, Amit Kucheria <amit.kuche...@linaro.org> >> wrote: >> >> > On Fri, Feb 17, 2012 at 11:03 AM, Deepak Saxena <dsax...@linaro.org> >> >> wrote: >> >> > >> >> >> - Various patches from Linaro >> >> >> >> >> >> * samsung_cpuidle_l2_retention patch set from the power management >> >> >> WG >> >> > >> >> > Amit, is this now in your maintainer's tree queued up for 3.4? >> > > _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev