On Mon, Feb 6, 2012 at 3:10 PM, Daniel Lezcano <daniel.lezc...@linaro.org> wrote: > On 02/06/2012 10:19 AM, Rickard Andersson wrote:
>> - there is no reason to place these functions inside the db8500-prcmu.c >> file. There is so much stuff in the PRCMU register base so we can not >> have everything in one file. Why not have it as it is? > > Why spread the prcmu code when it is related to the prcmu ? > > Linus ? What do you think ? I have no strong opinions on this. When I discussed it with Mattias who wrote much of the driver we concluded that the PRCMU drivers needs a lot of shaping up. Mainly it may need to be split into two parts: one which is a "pure" MFD device (register access part) one MFD firmware interaction part, and then a platform-specific (U8500) part. This would help getting code in more logical places. For now I would suggest not moving stuff around, I thin Mattias is onto cleaning up the structure as per above and we could be messing it up for him, which is not good. Yours, Linus Walleij _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
