On Tue, Jan 17, 2012 at 01:10:53AM +0800, Ying-Chun Liu (PaulLiu) wrote: > diff --git a/arch/arm/mach-mx5/board-mx53_loco.c > b/arch/arm/mach-mx5/board-mx53_loco.c > index fd8b524..61dd8c9 100644 > --- a/arch/arm/mach-mx5/board-mx53_loco.c > +++ b/arch/arm/mach-mx5/board-mx53_loco.c > @@ -23,10 +23,21 @@ > #include <linux/delay.h> > #include <linux/gpio.h>
You have this ^^^^^^^ include, which includes asm/gpio.h, and in turn mach/gpio.h, but... > #include <linux/i2c.h> > +#include <linux/module.h> > +#include <linux/platform_device.h> > +#include <linux/irq.h> > +#include <linux/interrupt.h> > +#include <linux/err.h> > +#include <linux/regulator/machine.h> > +#include <linux/regulator/fixed.h> > +#include <linux/mfd/da9052/da9052.h> > +#include <linux/mfd/da9052/pdata.h> > > #include <mach/common.h> > #include <mach/hardware.h> > #include <mach/iomux-mx53.h> > +#include <mach/irqs.h> > +#include <mach/gpio.h> you include mach/gpio.h here? I don't see why you need mach/irqs.h either. That brings into this another question: you're adding 9 new linux/ includes above. How many of those do you _actually_ need? Eg, I don't see you adding anything from linux/err.h to this file, so why do you need this header? Please don't add include files unnecessarily. _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
