Richard Zhao <richard.z...@linaro.org> writes: > The driver get cpu operation point table from device tree cpu0 node,
Since we already have an existing OPP infrastructure in the kernel, seems like this driver should get OPPs by asking the OPP layer. This approach assumes the OPP layer is static at boot time and not changing, however that's not the case in practice. The OPP layer could be extended to read boot-time OPPs from DT if desired, but since the OPPs are also populated/enabled/disabled dynamicaly on some platforms (e.g. OMAP), I think the any generic CPUfreq driver should use the OPP interface and not DT directly. > and adjusts operating points using clk and regulator APIs. For a generic driver, the regulator used should also be configurable. For example, this driver currently assumes a regulator named "cpu" for all instances. If you had separate clusters with independent voltage control, you'd likely have a separate regulator for each cluster. Kevin _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
