On Thu, Oct 20, 2011 at 11:46 AM, Barry Song <21cn...@gmail.com> wrote:
> 2011/10/20 Stephen Warren <swar...@nvidia.com>: >> A pin controller's pin definitions are used both during pinctrl_register() >> and pinctrl_unregister(). The latter happens outside of __init/__devinit >> time, and hence it is unsafe to mark the pin array as __refdata. > > Thanks. > Acked-by: Barry Song <baohua.s...@csr.com> > > missed this when porting prima2 pinmux driver. is this __refdata used > just due to a typo? No the problem was I misunderstood what __refdata means. It means it is kept around but can reference initidata. But I thought it meant "kept around in general". I don't think it's causing bugs actually because it wasn't referencing any initdata. But it's better like this. Thanks, Linus Walleij _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev