On Thu, Sep 22, 2011 at 03:26:59PM -0700, Mike Turquette wrote: > From: Jeremy Kerr <[email protected]> > > Signed-off-by: Jeremy Kerr <[email protected]> > Signed-off-by: Mark Brown <[email protected]> > Signed-off-by: Jamie Iles <[email protected]> > Signed-off-by: Mike Turquette <[email protected]> > --- > Changes since v1: > Add copyright header > Fold in Jamie's patch for set-to-disable clks > Use BIT macro instead of shift > > drivers/clk/Kconfig | 4 ++ > drivers/clk/Makefile | 1 + > drivers/clk/clk-gate.c | 78 > ++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/clk.h | 13 ++++++++ > 4 files changed, 96 insertions(+), 0 deletions(-) > create mode 100644 drivers/clk/clk-gate.c > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index d8313d7..a78967c 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -12,3 +12,7 @@ config GENERIC_CLK > config GENERIC_CLK_FIXED > bool > depends on GENERIC_CLK > + > +config GENERIC_CLK_GATE > + bool > + depends on GENERIC_CLK
I see zero documentation on what a "gated clock" is supposed to be or how it works, and there are zero comments in the code. It's kind of hard to review that way, and even harder to use. g. _______________________________________________ linaro-dev mailing list [email protected] http://lists.linaro.org/mailman/listinfo/linaro-dev
