2011/9/14 Per Forlin <per.for...@linaro.org>:
>>>> +static int fail_mmc_request_param_set(const char *val,
>>>> + const struct kernel_param *kp)
>>>> +{
>>>> + setup_fault_attr(&fail_default_attr, (char *) val);
> I am thinking of returning failure here if setup_fault_attr() fails.
> if (setup_fault_attr(&fail_default_attr, (char *) val) == 0)
> return -EINVAL;
It's good idea and it also prevents from loading the module if invalid
parameter is specified.
> There will be a printk(KERN_WARNING "FAULT_INJECTION: failed to parse
> arguments) it setup() fails. Is it too harsh to return failure?
Yes. I'll try to fix in the future.
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
